Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance of conv #634

Merged
merged 5 commits into from
May 7, 2024
Merged

improve performance of conv #634

merged 5 commits into from
May 7, 2024

Conversation

ericphanson
Copy link
Collaborator

julia> using Convex, BenchmarkTools

julia> x = rand(100_000);

julia> y = Variable(200);

julia> @btime conv($x, $y)

gives:

  1.286 s (56 allocations: 1.04 GiB) # master
  562.229 ms (37 allocations: 1.64 GiB) # PR

So 2x speed, but 1.6x allocations. I think it's a win overall, though not huge. Aimed at #376

test/test_atoms.jl Outdated Show resolved Hide resolved
src/reformulations/conv.jl Outdated Show resolved Hide resolved
src/reformulations/conv.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (96904be) to head (4ad7a93).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #634   +/-   ##
=======================================
  Coverage   97.86%   97.87%           
=======================================
  Files          88       88           
  Lines        5115     5127   +12     
=======================================
+ Hits         5006     5018   +12     
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericphanson ericphanson merged commit f2b37dd into master May 7, 2024
10 checks passed
@ericphanson ericphanson deleted the eph/optimize-1dconv branch May 7, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants