fix passing strings options to ScsSettings #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
Mar 17, 2022
kalmarek
commented
Mar 18, 2022
We keep values away from GC by @preserving model, hence scs structs must point to actual values stored there. A non-`String` value in model.option allocates a `String` when `Base.cconvert`ing which would need to be GC.@preserved separately from `model`
odow
reviewed
Mar 18, 2022
kalmarek
force-pushed
the
fix/string_options
branch
from
1d3cfd9
to
c9a7f81
Compare
odow
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.