Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix passing strings options to ScsSettings #253

Merged
merged 6 commits into from
Mar 20, 2022
Merged

fix passing strings options to ScsSettings #253

merged 6 commits into from
Mar 20, 2022

Commits on Mar 17, 2022

  1. fix passing strings options to ScsSettings

    @kalmarek
    kalmarek committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    8fe92c2 View commit details
    Browse the repository at this point in the history

  2. Update c_wrapper.jl

    @odow
    odow committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    3a45fdd View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. error on non-String values in model.options 

    We keep values away from GC by @preserving model, hence scs structs must
point to actual values stored there. A non-`String` value in
model.option allocates a `String` when `Base.cconvert`ing which would
need to be GC.@preserved separately from `model`
    @kalmarek
    kalmarek committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    3522214 View commit details
    Browse the repository at this point in the history

  2. format

    @kalmarek
    kalmarek committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    7df07b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2022

  1. avoid short-circuting

    @kalmarek
    kalmarek committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    c9a7f81 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2022

  1. bump to v1.1.1

    @kalmarek
    kalmarek committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    73501b4 View commit details
    Browse the repository at this point in the history