Fix JSON error when saving notebook with plotly figure #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After computing the png image, the `model.setData` call was treating plotly's traces array (`data`) as if it were the bundle's `data` property (`model.data`). This was causing a malformed bundle to be saved in the notebook, and causing only the image/png form to be restored on notebook load.
When opening a plotly figure from a file the `this.node.offsetWidth` and `this.node.offsetHeight` values are 0, which causes an error in `Plotly.toImage`. Add guards to not call `Plotly.toImage` unless width and height are positive numbers.
|
For context, I'm working on adding support to plotly.py to read/write JSON files that are compatible with this extension. I'm aiming for a release in about a week and I'd love to have these fixes available in a released version of |
|
LGTM, thanks! |
|
Published @jupyterlab/plotly-extension@0.17.2 |
|
Awesome, thanks @blink1073 !! |
|
👊 |
|
I think I was seeing this exact error today so good to know it's already fixed! 😄 |
This was referenced Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #158
It looks to me that after computing the png image, the
model.setDatacall was treatingplotly's traces array (
data) as if it were the bundle'sdataproperty (model.data).This was causing a malformed bundle to be saved in the notebook, and causing only the image/png form to be restored on notebook load.
cc @gnestor