Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON error when saving notebook with plotly figure #159

Merged
merged 2 commits into from
Sep 20, 2018

Commits on Sep 17, 2018

  1. Fix for GH 158.

    After computing the png image, the `model.setData` call was treating
    plotly's traces array (`data`) as if it were the bundle's `data`
    property (`model.data`).
    
    This was causing a malformed bundle to be saved in the notebook,
    and causing only the image/png form to be restored on notebook load.
    jonmmease committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    ecb0c95 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. Fix for GH 160.

    When opening a plotly figure from a file the `this.node.offsetWidth`
    and `this.node.offsetHeight` values are 0, which causes an error in
    `Plotly.toImage`.  Add guards to not call `Plotly.toImage` unless
    width and height are positive numbers.
    jonmmease committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    9f9992a View commit details
    Browse the repository at this point in the history