v5.1.0 - move normalize styles from base to optional

[dandel10n]

Changed

• Move normalize styles from base to optional. We had to copy the styles straight into the project to be able to make them optional wrapping them into a mixin.
  !!Note: If you don't use $includeBaseFramework or $includeMinimalFramework vars and want to have normalize styles in you project, you need to @include normalize() mixin starting from this version.

[ashleynolan]

Just a QQ – how did you generate this file? Looking at the project, I can see the 3 SCSS files, so just wondering if when new versions come out and we want to update this.

[dandel10n]

@ashleynolan I copied the output we have in the components.

[ashleynolan]

It might be worth following the package docs to use the approach stated on the package (can be done as a separate Engineering excellence ticket – just otherwise I'm not sure how we upgrade this if the normalise package upgrades in the future, as we won't be compiling it anywhere from the SCSS files then):

Approach 1: Download and use normalize-scss as a starting point for your own project's base Sass, customising the values to match the design's requirements. (The best approach, IMO.)

Copy the normalize-scss files to your sass directory so that you can alter it as you include it in your project.

So basically, take a copy of the SCSS directory in the package so we can then just copy/replace those files as needed in the future.

[DamianMullins]

One other thing to consider is that the normalize-scss package appears to be using a very old version of normalize.css (v5 compared to the most recent v8) and hasn't been updated for 4 years.

So maybe referencing normalize-scss is not the best approach?

[DamianMullins]

v8 is actually almost 3 years old itself — I'm guessing there aren't many reset updates to be made these days?

[ashleynolan]

Yeh, that's true. I guess we could just look to take in v8 itself then, as agree that it's not necessarily something that updates often. If we create a ticket for that, happy to merge this as-is

[dandel10n]

There is a discussion in the normalize project about better maintained up-to-date alternatives. I will create a ticket to look into it and replace