E2E testing using KinD #100
Conversation
martinkennelly
force-pushed
the
kind-e2e
branch
2 times, most recently
from
4ea1f4e
to
9290bdf
Compare
|
I tried to test this PR (by checking out directly your branch), but unfortunately I'm getting those errors: https://paste.opensuse.org/85826568 Any idea what I'm doing wrong? I'm running those with |
|
@mrostecki I have a feeling it is issue with KinD cluster or connectivity to the KinD cluster. Catch me on NPWG slack tomorrow and we can have a look. I sent you an email with slack contact details. I have seen this error when the test cases were unable to connect to KinD cluster so I added this command to the script: |
|
I am going to rework this patch to remove calling the pf network namespace setting from being called in the shell script to adding it into the test script itself. Thanks for feedback @mrostecki ! Hoping for more! |
hack/test-e2e-kind-cluster.sh
Outdated
| echo "## retrieving netns path from container" | ||
| netnspath="$(docker inspect --format '{{ .NetworkSettings.SandboxKey }}' "${kind_container}")" | ||
| echo "## deploying monitoring of PF/VF network namespace" | ||
| "${root}hack/pf-vf-netns-set" --pfpciaddress "${test_pf_pci_addr}" --netnspath "${netnspath}" & |
There was a problem hiding this comment.
I'd suggest doing it with sudo -E if the script is launched by an user.
martinkennelly
force-pushed
the
kind-e2e
branch
from
9290bdf
to
c080956
Compare
|
@mrostecki can you retest it? See the file |
There was a problem hiding this comment.
@martinkennelly Thanks! New changes LGTM and they work without any additional changes
Ran 5 of 5 Specs in 531.699 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestSriovTests (531.70s)
PASS
coverage: [no statements]
ok github.com/k8snetworkplumbingwg/sriov-network-operator/test/e2e 531.723s coverage: [no statements]
make: Leaving directory '/home/agabus/sriov-network-operator'
|
@martinkennelly could you rebase this PR. If I understand it correctly, we still need a machine with an SRIOV NIC to run this test, right? |
* Golang code to ensure VFs created during testing remain in test network namespace (KinD worker network namespace) * Shell script to fetch test tools, execute E2E tests using KinD and teardown KinD test environment Signed-off-by: Kennelly, Martin <martin.kennelly@intel.com> Signed-off-by: Patryk Strusiewicz-Surmacki <patrykx.strusiewicz-surmacki@intel.com>
Move PF/VF netns monitoring to test script to prevent escape processes during testing. Add logging to PF/VF monitoring. Increase in test log level required to view its output. PF/VF monitor does not exist when PF not found, assumes it is in correct netns and continues. Rename execution of KinD cluster and testing file to be consistent with existing files. Move e2e doc to docs. Signed-off-by: Kennelly, Martin <martin.kennelly@intel.com>
Signed-off-by: Martin Kennelly <martin.kennelly@intel.com>
Signed-off-by: Kennelly, Martin <martin.kennelly@intel.com>
Signed-off-by: Martin Kennelly <martin.kennelly@intel.com>
Signed-off-by: Martin Kennelly <martin.kennelly@intel.com>
|
@pliurh Done. I made one change following rebase captured in the head commit f116730 to disable the webhooks explicitly when testing E2E - a change enabled webhooks by default now. I think they should be enabled when we have sufficient tests for them.
Yes. You need to know the PCI address of a PF. |
Signed-off-by: Martin Kennelly <martin.kennelly@intel.com>
Add option to execute E2E tests using KinD
Depends on unmerged #97