-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let "depoly-setup.sh" and "undeploy.sh" fail on error #686
Let "depoly-setup.sh" and "undeploy.sh" fail on error #686
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 8755557051Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi @thom311 can you please do a force push I am not able to trigger the k8s lane for some reason |
Ignoring errors seems not best. It can make it harder to find problems with the script. If a command in the script is known to fail for valid reasons, then that should be treated specially (for example, with `|| :`). By default, treat any unexpected failure as fatal and propagate the failure to the caller. Fixes: 8844150 ('Add RBAC for cluster resource')
fea72a9
to
624a16f
Compare
/test-all |
Pull Request Test Coverage Report for Build 10455381530Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
all green merging nice work! |
Ignoring errors seems not best. It can make it harder to find problems with the script.
If a command in the script is known to fail for valid reasons, then that should be treated specially (for example, with
|| :
). By default, treat any unexpected failure as fatal and propagate the failure to the caller.Fixes: 8844150 ('Add RBAC for cluster resource')
CC: @pliurh