Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let "depoly-setup.sh" and "undeploy.sh" fail on error #686

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Let "depoly-setup.sh" and "undeploy.sh" fail on error #686

merged 1 commit into from
Aug 27, 2024
+3 −2

Commits on Aug 19, 2024

  1. Let "depoly-setup.sh" and "undeploy.sh" fail on error 

    Ignoring errors seems not best. It can make it harder to find problems
with the script.

If a command in the script is known to fail for valid reasons, then that
should be treated specially (for example, with `|| :`). By default,
treat any unexpected failure as fatal and propagate the failure to the
caller.

Fixes: 8844150 ('Add RBAC for cluster resource')
    @thom311
    thom311 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    624a16f View commit details
    Browse the repository at this point in the history