CI: Add a bash linter to pre-submits #781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following shellcheck error:
SC2068 (error): Double quote array expansions to avoid re-splitting elements.
https://www.shellcheck.net/wiki/SC2068
Fixes the following shellcheck error:
SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
https://www.shellcheck.net/wiki/SC2148
Fixes the following shellcheck errors:
SC2145 (error): Argument mixes string and array. Use * or separate argument.
SC2199 (error): Arrays implicitly concatenate in [[ ]]. Use a loop (or explicit * instead of @).
https://www.shellcheck.net/wiki/SC2145
https://www.shellcheck.net/wiki/SC2199
Also fixes a typo in SUPPORTED_INTERFACE_SWITCHER_MODES.
Fixes the following shellcheck error:
SC2045 (error): Iterating over ls output is fragile. Use globs.
https://www.shellcheck.net/wiki/SC2045
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 11066086546Details
💛 - Coveralls |
SchSeba
approved these changes
Sep 26, 2024
SchSeba
reviewed
Sep 26, 2024
mandre
force-pushed
the
shellcheck
branch
3 times, most recently
from
a18bf43
to
452f4e7
Compare
mandre
commented
Sep 26, 2024
test/scripts/rpm-ostree_mock
Outdated
| @@ -5,8 +5,8 @@ | |||
| # Write invocation with arguments to a file to allow making assertion. | |||
| echo "$*" >> /rpm-ostree_calls | |||
|
|
|||
| if [ "$*" != *"--append"* ] | |||
| then | |||
| # if [ "$*" != *"--append"* ] | |||
There was a problem hiding this comment.
@zeeke can you have a look at this please
There was a problem hiding this comment.
With this change, the test fail with:
+ chroot /host/ rpm-ostree kargs
+ /usr/sbin/chroot /tmp/tmp.gOQJTP0gp3 rpm-ostree kargs
+ grep -vq X=Y
/usr/sbin/chroot: failed to run command ‘rpm-ostree’: No such file or directory
Which doesn't really make sense to me. I'll try changing the shebang back to #!/usr/bin/sh to see if it makes a difference.
There was a problem hiding this comment.
OK, a5c53b5 worked.
I think this is ready for reviews now.
Fixes the following shellcheck error:
SC2081 (error): [ .. ] can't match globs. Use a case statement.
https://www.shellcheck.net/wiki/SC2081
Warns about shellcheck issues with severity `error`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new CI job that warns about shellcheck issues with severity
error, and fix all such errors in existing bash files.This should prevent errors such as the one fixed in #780 from entering the repo again.