Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add a bash linter to pre-submits #781

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Sep 23, 2024

  1. Enclose array expansions in double quote

    Fixes the following shellcheck error:
    
        SC2068 (error): Double quote array expansions to avoid re-splitting elements.
    
    https://www.shellcheck.net/wiki/SC2068
    mandre committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ba21df0 View commit details
    Browse the repository at this point in the history
  2. Add missing shebang

    Fixes the following shellcheck error:
    
        SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
    
    https://www.shellcheck.net/wiki/SC2148
    mandre committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3d553bf View commit details
    Browse the repository at this point in the history
  3. Explicitly expand array values

    Fixes the following shellcheck errors:
    
        SC2145 (error): Argument mixes string and array. Use * or separate argument.
        SC2199 (error): Arrays implicitly concatenate in [[ ]]. Use a loop (or explicit * instead of @).
    
    https://www.shellcheck.net/wiki/SC2145
    https://www.shellcheck.net/wiki/SC2199
    
    Also fixes a typo in SUPPORTED_INTERFACE_SWITCHER_MODES.
    mandre committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    63246d6 View commit details
    Browse the repository at this point in the history
  4. Iterate over globs.

    Fixes the following shellcheck error:
    
        SC2045 (error): Iterating over ls output is fragile. Use globs.
    
    https://www.shellcheck.net/wiki/SC2045
    mandre committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3529811 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Use grep for matching args with sh

    Fixes the following shellcheck error:
    
        SC2081 (error): [ .. ] can't match globs. Use a case statement.
    
    https://www.shellcheck.net/wiki/SC2081
    mandre committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a5c53b5 View commit details
    Browse the repository at this point in the history
  2. CI: Add a bash linter to pre-submits

    Warns about shellcheck issues with severity `error`.
    mandre committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0f06c98 View commit details
    Browse the repository at this point in the history