Review tweaks

kagkarlsson · Aug 27, 2023 · 89b42aa · 89b42aa
1 parent 135c51b
commit 89b42aa
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/db-scheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/MssqlJdbcCustomization.java b/db-scheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/MssqlJdbcCustomization.java
@@ -47,6 +47,7 @@ public String createSelectDueQuery(String tableName, int limit, String andCondit
     return "SELECT "
         + " * FROM "
         + tableName
+        // try reading past locked rows to see if that helps on deadlock-warnings
         + " WITH (READPAST) WHERE picked = ? AND execution_time <= ? "
         + andCondition
         + " ORDER BY execution_time ASC "

diff --git a/...cheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/MySQL8JdbcCustomization.java b/...cheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/MySQL8JdbcCustomization.java
@@ -19,7 +19,7 @@ public class MySQL8JdbcCustomization extends DefaultJdbcCustomization {
 
   @Override
   public String getName() {
-    return "MySQL";
+    return "MySQL => v8";
   }
 
   @Override

diff --git a/db-scheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/MySQLJdbcCustomization.java b/db-scheduler/src/main/java/com/github/kagkarlsson/scheduler/jdbc/MySQLJdbcCustomization.java
@@ -17,7 +17,7 @@ public class MySQLJdbcCustomization extends DefaultJdbcCustomization {
 
   @Override
   public String getName() {
-    return "MySQL";
+    return "MySQL < v8";
   }
 
   @Override

diff --git a/db-scheduler/src/test/resources/mariadb_tables.sql b/db-scheduler/src/test/resources/mariadb_tables.sql
@@ -1,3 +1,4 @@
+-- Best-effort schema definition based on MySQL schema. Please suggest improvements.
 create table test.scheduled_tasks (
   task_name varchar(40) not null,
   task_instance varchar(40) not null,