Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socketio 1.1 new #1258

Closed
wants to merge 3 commits into from
Closed

Conversation

dhimil
Copy link

@dhimil dhimil commented Dec 3, 2014

No description provided.

@sindresorhus
Copy link

@dhimil Looks like this needs to be rebased.

Can any of the maintainers review this? @karmarunnerbot

@maksimr
Copy link
Contributor

maksimr commented May 15, 2015

@dhimil Thanks!

Can you rebase on master, squash commits to one and change commit message following git commit message convention

@@ -264,7 +264,6 @@ var createSocketIoServer = function(webServer, executor, config) {
'client store expiration': 0,
logger: logger.create('socket.io', constant.LOG_ERROR),
resource: config.urlRoot + 'socket.io',
transports: config.transports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhimil Why we remove transports?
New version of socket.io does not allow setup transport?

dignifiedquire added a commit to dignifiedquire/karma that referenced this pull request May 15, 2015
dignifiedquire added a commit to dignifiedquire/karma that referenced this pull request May 15, 2015
dignifiedquire added a commit to dignifiedquire/karma that referenced this pull request May 17, 2015
dignifiedquire added a commit to dignifiedquire/karma that referenced this pull request May 17, 2015
dignifiedquire added a commit to dignifiedquire/karma that referenced this pull request May 17, 2015
@dignifiedquire
Copy link
Member

Superseded by #1404

lygstate pushed a commit to lygstate/karma that referenced this pull request May 27, 2015
dignifiedquire added a commit to dignifiedquire/karma that referenced this pull request May 27, 2015
shirish87 pushed a commit to shirish87/karma that referenced this pull request Aug 29, 2015
This superseeds karma-runner#1257 and karma-runner#1258.
Closes karma-runner#1220.

Conflicts:
	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants