Force karma to use the latest 0.9.x working version of socket.io #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running karma tests with `ddescribe` or `iit`, as well as in some other cases, the browser gets disconnected for some reason. The full information on this fix can be found in: http://jamiolkowski.it/251/karma-runner-warn-chrome-35-0-1916-mac-os-x-10-8-5-disconnected-1-times/
|
Yes, there is a branch with upgrading to socket.io 1.0. In the meantime I think this is a good fix. |
|
Thanks @vojtajina, can you tell me what is the problem with the tests in travis ci? Seems that it passed the tests but then something else broke it, but I'm not sure what it is. |
|
@alias-mac fixed problem with CI. It's not your fault |
|
Landed as 840ee5f |
|
Thank you @alias-mac |
|
Huge thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running karma tests with
ddescribeoriit, as well as in some othercases, the browser gets disconnected for some reason.
The full information on this fix can be found in:
http://jamiolkowski.it/251/karma-runner-warn-chrome-35-0-1916-mac-os-x-10-8-5-disconnected-1-times/