Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review CodeQL rules and enable it on PRs #4032

Closed
JorTurFer opened this issue Dec 21, 2022 · 0 comments · Fixed by #4133
Closed

Review CodeQL rules and enable it on PRs #4032

JorTurFer opened this issue Dec 21, 2022 · 0 comments · Fixed by #4133
Assignees
@JorTurFer
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@JorTurFer
Copy link
Member

Proposal

Currently, we are executing CodeQL but there are some useful scenarios we are not covering, for example, the rule go/missing-error-check is not detected and could be interesting for us.
We should review CodeQL workflow because maybe we have introduced any misconfiguration over the time an it isn't working properly

Use-Case

No response

Anything else?

No response
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Dec 21, 2022
@JorTurFer JorTurFer self-assigned this Dec 21, 2022
@JorTurFer JorTurFer mentioned this issue Jan 17, 2023
Merged
2 tasks
JorTurFer added a commit that referenced this issue Jan 18, 2023
@JorTurFer
chore: Review CodeQL config (#4133)
a25f1a4 
Fixes #4032
JorTurFer added a commit to JorTurFer/keda that referenced this issue Jan 18, 2023
@JorTurFer
chore: Review CodeQL config (kedacore#4133)
e2ba940 
Fixes kedacore#4032
JorTurFer added a commit to JorTurFer/keda that referenced this issue Jan 18, 2023
@JorTurFer
chore: Review CodeQL config (kedacore#4133)
831a787 
Fixes kedacore#4032

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
JorTurFer added a commit that referenced this issue Jan 18, 2023
@JorTurFer
feat: Use e2e testing infrastructure (#3753) (#4139)
fde94f9 
* feat: Use e2e testing infrastructure (#3753)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* chore: Review CodeQL config (#4133)

Fixes #4032

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer mentioned this issue Jan 19, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JorTurFer JorTurFer

Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Review CodeQL config JorTurFer/keda
1 participant
@JorTurFer