Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use e2e testing infrastructure #3753

Merged
merged 17 commits into from
Nov 11, 2022
Merged

feat: Use e2e testing infrastructure #3753

merged 17 commits into from
Nov 11, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Oct 15, 2022

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

This PR changes the e2e infrastructure to use the new resources managed by terraform in https://github.com/kedacore/testing-infrastructure and improves also how we managed the secrets automatically creating environment variables for each secret, removing the requirement of creating a PR enabling new secrets (now automatically generated from infrastructure repository)

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to kedacore/governance#77

@JorTurFer JorTurFer changed the title WIP - feath: Use new environment variables WIP - feat: Use new environment variables autogenerated Oct 15, 2022
@JorTurFer JorTurFer force-pushed the switch-to-tf branch 3 times, most recently from abe0a7b to 18d207a Compare November 8, 2022 23:16
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
JorTurFer and others added 13 commits November 9, 2022 01:42
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
.
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
.
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
.
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer changed the title WIP - feat: Use new environment variables autogenerated feat: Use new environment variables autogenerated Nov 11, 2022
@JorTurFer JorTurFer marked this pull request as ready for review November 11, 2022 11:35
@JorTurFer JorTurFer requested a review from a team as a code owner November 11, 2022 11:35
@JorTurFer JorTurFer changed the title feat: Use new environment variables autogenerated feat: Use e2e testing infrastructure Nov 11, 2022
@JorTurFer JorTurFer force-pushed the switch-to-tf branch 2 times, most recently from 9ec7da4 to cb6a124 Compare November 11, 2022 11:50
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer enabled auto-merge (squash) November 11, 2022 12:02
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 76310a8 into main Nov 11, 2022
@zroubalik zroubalik deleted the switch-to-tf branch November 11, 2022 12:48
@JorTurFer JorTurFer mentioned this pull request Jan 18, 2023
7 tasks
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Jan 18, 2023
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
JorTurFer added a commit that referenced this pull request Jan 18, 2023
* feat: Use e2e testing infrastructure (#3753)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* chore: Review CodeQL config (#4133)

Fixes #4032

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants