You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.
Being able to save an invalid Archetype as draft (#151, fixed in #311) is nice, but with the various performance fixes and subsequent lazy loading of fieldsets, this feature enables the editors to publish invalid data.
When the Archetype is saved with invalid data in a fieldset, it reloads the editor and all validation state is reset (the fieldset is collapsed). Thus it has no idea that the fieldset is invalid, and the editors can hit publish without being prompted to correct the invalid data.
It's a catch 22, given the current validation handling. We're forced to choose between the "save as draft" feature and having valid published data. I'm going to choose the latter, so I'll remove the fix introduced in #311 - at least for the time being. Perhaps we can revisit this another time, if the demand for "save as draft" grows.
The text was updated successfully, but these errors were encountered:
Being able to save an invalid Archetype as draft (#151, fixed in #311) is nice, but with the various performance fixes and subsequent lazy loading of fieldsets, this feature enables the editors to publish invalid data.
When the Archetype is saved with invalid data in a fieldset, it reloads the editor and all validation state is reset (the fieldset is collapsed). Thus it has no idea that the fieldset is invalid, and the editors can hit publish without being prompted to correct the invalid data.
It's a catch 22, given the current validation handling. We're forced to choose between the "save as draft" feature and having valid published data. I'm going to choose the latter, so I'll remove the fix introduced in #311 - at least for the time being. Perhaps we can revisit this another time, if the demand for "save as draft" grows.
The text was updated successfully, but these errors were encountered: