Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

Saving without publishing potentially causes invalid published data #385

Closed
kjac opened this issue Feb 16, 2017 · 1 comment
Closed

Saving without publishing potentially causes invalid published data #385

kjac opened this issue Feb 16, 2017 · 1 comment
Assignees

Comments

@kjac
Copy link
Contributor

kjac commented Feb 16, 2017

Being able to save an invalid Archetype as draft (#151, fixed in #311) is nice, but with the various performance fixes and subsequent lazy loading of fieldsets, this feature enables the editors to publish invalid data.

When the Archetype is saved with invalid data in a fieldset, it reloads the editor and all validation state is reset (the fieldset is collapsed). Thus it has no idea that the fieldset is invalid, and the editors can hit publish without being prompted to correct the invalid data.

It's a catch 22, given the current validation handling. We're forced to choose between the "save as draft" feature and having valid published data. I'm going to choose the latter, so I'll remove the fix introduced in #311 - at least for the time being. Perhaps we can revisit this another time, if the demand for "save as draft" grows.

@kjac kjac self-assigned this Feb 16, 2017
@kjac kjac added the bug label Feb 16, 2017
@kgiszewski
Copy link
Owner

I'm thinking the core has to provide some sort of way to help us determine these things.

I realize the core team doesn't really like nested data types, so I'm not terribly optimistic :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants