Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

Fix save without validation #311

Merged
merged 1 commit into from
Mar 22, 2016
Merged

Conversation

kgiszewski
Copy link
Owner

Fix #151

Depends on:
umbraco/Umbraco-CMS#949

@kgiszewski
Copy link
Owner Author

A discussion going on regarding the PR that would pave the way for this feature: http://issues.umbraco.org/issue/U4-7534

Input/votes would be appreciated.

@kjac
Copy link
Contributor

kjac commented Dec 17, 2015

Hey @kgiszewski ... I haven't tested this, but based on a quick code glance, couldn't you test on args.statusMessage !== "Saving..." or args.statusMessage.toLowerCase().indexOf("save") == 0 instead of args.action !== "save" @ https://github.com/imulus/Archetype/pull/311/files#diff-32c2318424d5b011a544698c71ada331R118? Or is the statusMessage not passed along as part of args?

It's not that I disagree with your core PR at all, but by the sound of things, Shannon doesn't feel like merging it in. On top of that, using the statusMessage would be backwards compatible.

@kgiszewski
Copy link
Owner Author

@kjac, it'll likely not get merged and at last check the statusMessage doesn't make it to the property editor.

This is where that break happens: https://github.com/kgiszewski/Umbraco-CMS/blob/dev-v7/src/Umbraco.Web.UI.Client/src/common/services/formhelper.service.js#L53

The core only passes the args.scope instead of the full args. I added the action to make it cleaner... meh.

If the full args got passed, then yes I could :) Either way a change needs to be made. Oh well, I tried :)

@kjac
Copy link
Contributor

kjac commented Dec 17, 2015

@kgiszewski ungh :(

Yeah, you tried. I think it's a nice addition. Fingers crossed it will make it in.

@kgiszewski
Copy link
Owner Author

A core fix is due in 7.4.2 to possibly allow this to work.

@kgiszewski
Copy link
Owner Author

The core PR was accepted. Will reevaluate my PR here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants