Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM package tests need to run before publishing Golang code #21

Closed
aliok opened this issue Jan 8, 2024 · 4 comments · Fixed by #78
Closed

NPM package tests need to run before publishing Golang code #21

aliok opened this issue Jan 8, 2024 · 4 comments · Fixed by #78

Comments

@aliok
Copy link
Member

aliok commented Jan 8, 2024

Related: #13 (comment)

When we create a release of Golang part, GitHub actions automatically create a release of the plugin. However, the Golang release process does not run the tests for the plugin. So, we might end up in a situation where the tests of Golang is fine but plugin is not.

Thus, before releasing the Golang part, we also need to run the plugin tests.

Copy link

github-actions bot commented Apr 8, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2024
@aliok
Copy link
Member Author

aliok commented Apr 15, 2024

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2024
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 15, 2024
@aliok
Copy link
Member Author

aliok commented Aug 7, 2024

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant