New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release setup #13

Merged

knative-prow merged 6 commits into knative-extensions:main from aliok:2023-12-21-release-setup

Jan 2, 2024

Member

aliok commented Dec 21, 2023 •

edited

Loading

Changes

Release tooling and actions
We have the Backstage plugin and the backend it talks to in the same repo.
Currently there's only 1 plugin and 1 backend, but we can have multiple in the future in the same repository.
Golang release will need a trigger (in Add blank config for knative-extensions/backstage-plugins knative/infra#295 --> to be updated)
NPM release will be triggered when the Golang trigger creates a release on GitHub (see https://github.com/knative-extensions/backstage-plugins/pull/13/files#diff-f94d9b46e48dd84224634aa7ef4b8f7caae2afa59f5c2f79517da7e7da5fe32bR7-R8).
NPM release process will get the release version from GitHub release name and publish the NPM package with the same version (see https://github.com/knative-extensions/backstage-plugins/pull/13/files#diff-f94d9b46e48dd84224634aa7ef4b8f7caae2afa59f5c2f79517da7e7da5fe32bR60-R65).
Until GitHub gives us the NPM knative org (see my message on Slack for the name dispute I've filed), the NPM package is published to knative-extensions NPM org that I own.

/kind

Fixes #

Release Note

Docs

aliok added 3 commits

December 21, 2023 14:56


          Release setup for backend

86e09cf

Signed-off-by: Ali Ok <aliok@redhat.com>


          Release setup for plugins

903e51b

Signed-off-by: Ali Ok <aliok@redhat.com>


          Fix NPM publish

0ae6f8f

Signed-off-by: Ali Ok <aliok@redhat.com>

knative-prow bot commented Dec 21, 2023

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

Release tooling and actions

Golang release will need a trigger (in Add blank config for knative-extensions/backstage-plugins knative/infra#295 --> to be updated)

NPM release will be triggered when the Golang trigger creates a release on GitHub.

Version bump for NPM release is not done yet.

/kind

Fixes #

Release Note
Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow bot added the do-not-merge/work-in-progress label

knative-prow bot requested review from krsna-m and psschwei

December 21, 2023 11:59

knative-prow bot added approved size/L labels

aliok added 2 commits

December 21, 2023 15:03


          Switch plugin main version to 0.0.0-nightly

Signed-off-by: Ali Ok <aliok@redhat.com>


          Set release version of NPM package to GitHub release name

057d02d

Signed-off-by: Ali Ok <aliok@redhat.com>

aliok marked this pull request as ready for review

December 21, 2023 12:15

knative-prow bot removed the do-not-merge/work-in-progress label

knative-prow bot requested review from creydr and dsimansk

December 21, 2023 12:15

Member Author

aliok commented Dec 21, 2023

cc @knative-extensions/productivity-leads
@cardil @upodroid

Member Author

aliok commented Jan 2, 2024

pierDipi reviewed

View reviewed changes

.github/workflows/backstage-release.yaml

Comment on lines +4 to +5

		# When manually triggered
		workflow_dispatch:

Member

pierDipi Jan 2, 2024

Should this manual trigger have inputs ? Otherwise actions/checkout@v4 will checkout the default branch main

Member Author

aliok Jan 2, 2024

You can select the branch in GitHub UI and then trigger the workflow. No need for any inputs. ...unless there's something I am missing

Member Author

aliok Jan 2, 2024

Should be good now

.github/workflows/backstage-release.yaml Outdated

+                    - name: Print release name
+                      run: |
+                        echo "Release name: ${{ github.event.release.name }}"

Member

pierDipi Jan 2, 2024

I think this variable is not present when this is triggered on workflow_dispatch

Member Author

aliok Jan 2, 2024

Good point

Member Author

aliok Jan 2, 2024

Should be good now

.github/workflows/backstage-release.yaml

Comment on lines +45 to +50

+                    - name: Run tests
+                      shell: bash
+                      working-directory: ./backstage
+                      run: |
+                        export PATH="./node_modules/.bin/:$PATH"
+                        yarn test

Member

pierDipi Jan 2, 2024

Running tests here seems a good additional check, however, I think we need to run the tests before Prow publishes a release in the Prow jobs

Member Author

aliok Jan 8, 2024

Created #21

.github/workflows/backstage-release.yaml Outdated

+                      working-directory: ./backstage/plugins/knative-event-mesh-backend
+                      run: |
+                        export PATH="./node_modules/.bin/:$PATH"
+                        yarn version --new-version ${{ github.event.release.name }} --no-git-tag-version

Member

pierDipi Jan 2, 2024

I think this variable is not present when this is triggered on workflow_dispatch

Member Author

aliok Jan 2, 2024

Should be good now

.github/workflows/backstage-release.yaml

Member

pierDipi Jan 2, 2024

Prow publishes nightly releases, should we do the same for the NPM package?

Member Author

aliok Jan 2, 2024

We definitely can. I don't think I would bind the NPM publish to the Prow's schedule then. Just a periodic (or, whenever something is pushed) that lives on Github actions.

Created #15, thanks for the idea.

pierDipi reviewed

View reviewed changes

.github/workflows/backstage-release.yaml

Member

pierDipi Jan 2, 2024

For this workflow, I think it's important that we get notifications for success / failure similar to https://cloud-native.slack.com/archives/C04LY4Y3EHF/p1698337431944799

Member Author

aliok Jan 2, 2024

Let me do that as an improvement later, ok?

Created #14


          Allow passing release name to the manual workflow dispatch

262bb37

Signed-off-by: Ali Ok <aliok@redhat.com>

This was referenced Jan 2, 2024

NPM publish process should send a Slack notification #14

Closed

Nightly publish NPM packages #15

Closed

pierDipi approved these changes

View reviewed changes

Member

pierDipi left a comment

/lgtm
/approve

Thanks for capturing improvements too!

knative-prow bot assigned pierDipi

knative-prow bot added the lgtm label

knative-prow bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [aliok,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow bot merged commit 6d300aa into knative-extensions:main

15 checks passed

aliok mentioned this pull request

NPM package tests need to run before publishing Golang code #21

Closed

aliok added a commit to aliok/backstage-plugins that referenced this pull request


          Update README.md (knative-extensions#13)

f420d40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/L