Do not perform osquery healthchecks while system is sleeping #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/skip-healthcheck-on-power-event
branch
from
6dc940d
to
cb5f07e
Compare
James-Pickett
previously approved these changes
Aug 7, 2023
directionless
previously approved these changes
Aug 7, 2023
pkg/agent/flags/keys/keys.go
Outdated
| @@ -47,6 +47,7 @@ const ( | |||
| LogIngestServerURL FlagKey = "log_ingest_url" | |||
| TraceIngestServerURL FlagKey = "trace_ingest_url" | |||
| DisableTraceIngestTLS FlagKey = "disable_trace_ingest_tls" | |||
| DisableOsqueryHealthchecks FlagKey = "disable_osquery_healthchecks" | |||
There was a problem hiding this comment.
Thoughts about whether should do this as DisableOsqueryHealthchecks vs PowersaveMode?
There was a problem hiding this comment.
I had gone back and forth on similar too, thinking about this versus something like InModernStandby. I ended up on this one because the osquery extension doesn't need to know why it should skip healthchecks, just what to do -- but I do not feel that strongly about it.
There was a problem hiding this comment.
Updated per offline discussion!
RebeccaMahany
dismissed stale reviews from directionless and James-Pickett
via
5e98671
directionless
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We occasionally see an issue where launcher shuts itself down on Windows while the device is sleeping, and fails to be restarted successfully. Our best guess is that while in modern standby, launcher is throttled and the osquery healthcheck therefore fails enough to shut down launcher, and the throttling prevents launcher from starting back up. This PR disables the osquery healthcheck while the system is sleeping.