Fix an infinite exec bug #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FindNewestSelf function calls FindNewest. Which, in turns, calls `checkExecutable`. Which launchers the binary. Which goes back to the beginning. This bug only manifests for `launcher`, but not for the `osquery` side. This isn't a fatal error, as there's a 5s timeout on it. But it is slow. Add an option to skip the final check, solving this. And add comments.
blaedj
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
couple spelling nits, but I think this looks good.
This is probably just my lack of understanding, but I'm trying to figure out why we don't need to use this option in other calls to findNewest, e.g. updater-finalizer.go:29, since that passes os.Args[0] as the binary path - wouldn't that also be the path to the currently running binary?
Co-Authored-By: blaedj <blaedj@users.noreply.github.com>
Good catch, I think that needs this option as well. Though I wonder why it's not using |
Co-Authored-By: blaedj <blaedj@users.noreply.github.com>
blaedj
approved these changes
Apr 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FindNewestSelf function calls FindNewest. Which, in turns, calls
checkExecutable. Which launchers the binary. Which goes back to the beginning. This bug only manifests forlauncher, but not for theosqueryside. This isn't a fatal error, as there's a 5s timeout on it. But it is slow.Add an option to skip the final check, solving this. And add comments.
Convert the finalizers over to using
FindNewestSelf. First, because that's what it's there for. Second, becauseos.Executable()is more correct thanos.Args[0]