Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an infinite exec bug #595

Merged
merged 4 commits into from
Apr 2, 2020
Merged

Fix an infinite exec bug #595

merged 4 commits into from
Apr 2, 2020

Commits on Apr 2, 2020

  1. Fix an infinit exec recursion bug 

    The FindNewestSelf function calls FindNewest. Which, in turns, calls `checkExecutable`. Which launchers the binary. Which goes back to the beginning. This bug only manifests for `launcher`, but not for the `osquery` side. This isn't a fatal error, as there's a 5s timeout on it. But it is slow.

Add an option to skip the final check, solving this. And add comments.
    @directionless
    directionless committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    4480222 View commit details
    Browse the repository at this point in the history

  2. Update cmd/launcher/main.go 

    Co-Authored-By: blaedj <blaedj@users.noreply.github.com>
    @directionless @blaedj
    directionless and blaedj authored Apr 2, 2020
    Configuration menu
    Copy the full SHA
    d51ac76 View commit details
    Browse the repository at this point in the history

  3. Update cmd/launcher/main.go 

    Co-Authored-By: blaedj <blaedj@users.noreply.github.com>
    @directionless @blaedj
    directionless and blaedj authored Apr 2, 2020
    Configuration menu
    Copy the full SHA
    49cb8fe View commit details
    Browse the repository at this point in the history

  4. Finializer should use the FindNewestSelf mechanism

    @directionless
    directionless committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    e66da36 View commit details
    Browse the repository at this point in the history