Add metrics match for PR check #835
Conversation
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
| createExperimentCount_STATUS = "Metric Category: API, Metric Type: count, Name: createExperiment, Value: 10.0" | ||
| createExperimentSum_STATUS = "Metric Category: API, Metric Type: sum, Name: createExperiment, Value: 0.228229311" | ||
| listRecommendationsCount_STATUS = "Metric Category: API, Metric Type: count, Name: listRecommendations, Value: 11.0" | ||
| listRecommendationsSum_STATUS = "Metric Category: API, Metric Type: sum, Name: listRecommendations, Value: 0.349422898" |
There was a problem hiding this comment.
@kusumachalasani - I think count may not change but sum can change even for the same no. of exps / results. Have you run this multiple times to check this? Should we specify a range instead?
There was a problem hiding this comment.
On my system, the sum remained the same. I need to validate if it is same for systems where the PR check is run.
Also, the sum values mentioned here needs to be updated after the first run that happens on the system where PR check is run considering the resources it has. Will wait for the Bharath fix to validate.
I have a plan to introduce the ranges, but as I mentioned want to validate the data first on these systems.
There was a problem hiding this comment.
You can create the github workflow and run it from your branch by commenting out the failing assertion.
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
rbadagandi1
modified the milestones:
Kruize 0.0.16_rm Release,
Kruize 0.0.17_rm Release
dinogun
modified the milestones:
Kruize 0.0.17_rm Release,
Kruize 0.0.19_rm Release,
Kruize 0.0.18_rm Release
rbadagandi1
modified the milestones:
Kruize 0.0.20.2_rm Release,
Kruize 0.0.21_rm Release
rbadagandi1
modified the milestones:
Kruize 0.0.22_rm Release,
Kruize 0.0.23_rm Release
|
Closing stale PRs |
This fixes #819