-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Metrics status #889
Conversation
@kusumachalasani - I couldn't find the metrics API in monitoringAPI.md, can you please point me to the documentation. Also ensure the documentation is updated with these changes and update the tests to check for status. |
Updated the documentation. Will be updating the tests related to this as part of PR #835 |
e747dd9
to
2fe9931
Compare
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
2fe9931
to
ecce238
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enable "status" for metrics of Kruize API and DB methods.
Below is one of the metric which shows both success and failure status.