Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Metrics status #889

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Conversation

kusumachalasani
Copy link
Contributor

Enable "status" for metrics of Kruize API and DB methods.
Below is one of the metric which shows both success and failure status.

kruizeAPI_count{api="listExperiments",application="Kruize",method="GET",status="failure",} 7.0
kruizeAPI_sum{api="listExperiments",application="Kruize",method="GET",status="failure",} 0.015359167
kruizeAPI_count{api="listExperiments",application="Kruize",method="GET",status="success",} 3.0
kruizeAPI_sum{api="listExperiments",application="Kruize",method="GET",status="success",} 0.003072515

@chandrams
Copy link
Contributor

@kusumachalasani - I couldn't find the metrics API in monitoringAPI.md, can you please point me to the documentation. Also ensure the documentation is updated with these changes and update the tests to check for status.

@kusumachalasani kusumachalasani changed the base branch from mvp_demo to master July 21, 2023 10:12
@kusumachalasani
Copy link
Contributor Author

kusumachalasani commented Jul 24, 2023

Updated the documentation. Will be updating the tests related to this as part of PR #835

@kusumachalasani kusumachalasani changed the base branch from master to mvp_demo August 21, 2023 07:03
@kusumachalasani kusumachalasani force-pushed the metrics-status branch 2 times, most recently from e747dd9 to 2fe9931 Compare August 22, 2023 07:01
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
Signed-off-by: kusumachalasani <kchalasa@redhat.com>
Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit d649009 into kruize:mvp_demo Aug 22, 2023
1 of 2 checks passed
@dinogun dinogun added this to the Kruize 0.0.18_rm Release milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants