This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Move the ferry e2e tests to FerrySuite #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiachengxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
|
Can we first get #114 merged than this? |
|
Also in that PR are |
thetechnick
suggested changes
Jan 9, 2020
|
I think the refactoring should be done in a dedicated PR |
|
/retest |
|
/hold |
kubermatic-bot
added
the
do-not-merge/hold
kubermatic-bot
added
size/M
nmiculinic
changed the title
jiachengxu
commented
Jan 15, 2020
kubermatic-bot
added
the
needs-rebase
kubermatic-bot
removed
the
needs-rebase
|
/lgtm |
kubermatic-bot
removed
the
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 0ff4572e625af7bc626041387be4444a9620da15
|
thetechnick
pushed a commit
that referenced
this pull request
Jan 27, 2020
* Move the ferry tests to ProviderSuite * change the default namespce to provider namespace. * Remove the t.parallel() to test * performed necessary refactoring * disabling parallel test * Added sepcfic provider, not randomly in the default namespace Co-authored-by: Neven Miculinic <neven.miculinic@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: