Add snapshot size to VSC created for VGS

[Madhu-1]

Currently the RestoreSize is missing when the corresponding VSC are created for the the volumesnapshotgroup, This PR adds the missing RestoreSize for VSC.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1002

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

This change will update the Restore size in volumesnapshotcontent to the size it's received from the CSI driver. If `0` is received, it won't be added to the Restore size as it means it is unspecified as per CSI spec.

[k8s-ci-robot]

Hi @Madhu-1. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Madhu-1]

/assign @xing-yang
/assign @nixpanic

[nixpanic]

I wonder if all the pointers to size int64 is really needed. size == 0 already indicates that the value is optional from a CSI Spec point of view:

// Information about a specific snapshot.
message Snapshot {
  // This is the complete size of the snapshot in bytes. The purpose of
  // this field is to give CO guidance on how much space is needed to
  // create a volume from this snapshot. The size of the volume MUST NOT
  // be less than the size of the source snapshot. This field is
  // OPTIONAL. If this field is not set, it indicates that this size is
  // unknown. The value of this field MUST NOT be negative and a size of
  // zero means it is unspecified.
  int64 size_bytes = 1;

This indicates an existing bug when RestoreSize: 0 is set. It should probably never be set to 0 at all.

[Madhu-1]

that also works, remove the pointer and added size >0 check

[nixpanic]

Looks reasonable to me. Can you confirm it addresses issue #1002 ?

/ok-to-test

[Madhu-1]

below is the volumesnapshotcontent after the fix, i can see restoreSize is set to expected value

[$]kubectl get volumesnapshotcontent snapcontent-e67b491e059be31f49753afffe159d8a9952b7039027558fe7fb4fd7fedec218-2024-02-14-2.37.11 -oyaml
apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshotContent
metadata:
  creationTimestamp: "2024-02-14T14:37:11Z"
  finalizers:
  - snapshot.storage.kubernetes.io/volumesnapshotcontent-bound-protection
  generation: 2
  name: snapcontent-e67b491e059be31f49753afffe159d8a9952b7039027558fe7fb4fd7fedec218-2024-02-14-2.37.11
  resourceVersion: "275842"
  uid: 7b365bcd-741c-4a26-94e9-972826dec2c7
spec:
  deletionPolicy: Delete
  driver: rook-ceph.cephfs.csi.ceph.com
  source:
    snapshotHandle: 0001-0009-rook-ceph-0000000000000001-1a14a2e3-6bbe-48d2-8b48-f47d4a7a1cab
  volumeSnapshotRef:
    kind: VolumeSnapshots
    name: snapshot-e67b491e059be31f49753afffe159d8a9952b7039027558fe7fb4fd7fedec218-2024-02-14-2.37.11
    namespace: default
    uid: a7fb44af-6137-4801-b132-ad12b9464506
status:
  creationTime: 1707921431731229233
  readyToUse: true
  restoreSize: 1073741824
  snapshotHandle: 0001-0009-rook-ceph-0000000000000001-1a14a2e3-6bbe-48d2-8b48-f47d4a7a1cab
  volumeGroupSnapshotHandle: 0001-0009-rook-ceph-0000000000000001-b76b4108-7d72-404c-aad0-e23e1fc2ac8b

[nixpanic]

/lgtm

[nixpanic]

/kind bug

[xing-yang]

Can you add a release note?

[Madhu-1]

Can you add a release note?

@xing-yang updated the release notes, can you please check and let me know if there is any other suggestion on it.

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment