Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport volumegroupsnapshot commits to release-7.0 #1043

Closed
wants to merge 5 commits into from
Closed

backport volumegroupsnapshot commits to release-7.0 #1043

wants to merge 5 commits into from

Conversation

Madhu-1
Copy link
Contributor

@Madhu-1 Madhu-1 commented Mar 26, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR cherry-picks the below PRs to the release-7.0 branch which helps to support the volumegroupsnapshot feature in the next 7.x release.

#1014
#1015
#1011
#1034

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Madhu-1 and others added 5 commits March 26, 2024 10:51
@Madhu-1
Add snapshot size to VSC created for VGS
3fce69f 
Currently the RestoreSize is missing when
the corresponding VSC are created for the
the volumesnapshotgroup, This PR adds the missing
RestoreSize for VSC.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 5a7115d)
@Madhu-1
fix method name in logging
28d6ee4 
updating code to use correct method
names for logging.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 0fe3abb)
@Madhu-1
use GroupSnapshotDeleteError type for event
8e032bc 
use GroupSnapshotDeleteError as event type for
event incase if there is any failure in delete
operation.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 5706ab6)
@nixpanic @Madhu-1
Fix detecting default annotation on VolumeGroupSnapshotClass
12a2568 
The `IsDefaultAnnotation()` function has been extended to check for the
correct default annotation, taking the Kind of the object into
consideration.

(cherry picked from commit aa837d1)
@manishym @Madhu-1
Add snapshot secret reference to group snapshot controller.
812cae3 
Fixes: kubernetes-csi#834
Signed-off-by: Manish <myathnal@redhat.com>
(cherry picked from commit e171a98)
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Madhu-1. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Madhu-1
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2024
@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Mar 26, 2024

/assign @xing-yang @nixpanic

@Madhu-1 Madhu-1 changed the title backport volumegroupsnapshot comitsto release-7.0 backport volumegroupsnapshot commits to release-7.0 Mar 26, 2024
@xing-yang
Copy link
Collaborator

Can you separate these backports into different PRs? It's easier to review this way. Thanks.

@Madhu-1
Copy link
Contributor Author

Madhu-1 commented Mar 26, 2024

@xing-yang sure i can do that, closing this one to send separate PR's

@Madhu-1 Madhu-1 closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@yuxiangqian yuxiangqian Awaiting requested review from yuxiangqian

Assignees

@nixpanic nixpanic

@xing-yang xing-yang

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Madhu-1 @k8s-ci-robot @xing-yang @nixpanic @manishym