Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart] 0.9.6 StorageClass Missing YAML Document Separator #750

Closed
aballman opened this issue Feb 18, 2021 · 7 comments
Closed

[chart] 0.9.6 StorageClass Missing YAML Document Separator #750

aballman opened this issue Feb 18, 2021 · 7 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@aballman
Copy link

/kind bug

What happened?
When using the storageClasses field in the helm chart and providing multiple entries, the generated yaml does not include the document separator ---

# Source: aws-ebs-csi-driver/templates/storageclass.yaml
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: sc1
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: sc2
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer

What you expected to happen?
The same yaml is generated with the document separator, so that N resources are created instead of 1.

# Source: aws-ebs-csi-driver/templates/storageclass.yaml
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: sc1
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer
---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: sc2
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer

How to reproduce it (as minimally and precisely as possible)?
Using the following for your values

storageClasses:
- name: "sc1"
- name: "sc2"

Anything else we need to know?:
Nope

Environment

  • Kubernetes version (use kubectl version): 1.18.9 EKS
  • Driver version: 3.0.3
  • Chart version: 0.9.6
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 18, 2021
@ayberk
Copy link
Contributor

ayberk commented Feb 22, 2021

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@ayberk:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 22, 2021
@nvnmandadhi
Copy link
Contributor

I'd like to help with this, I'd be looking to change the Storageclass template, right?

@nvnmandadhi
Copy link
Contributor

/assign

@krmichel
Copy link
Contributor

@ayberk looks like PR #762 was merged but not connected to this issue. Looks like it can be closed.

@ayberk
Copy link
Contributor

ayberk commented Mar 26, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@ayberk: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants