Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a document separator for storageclass template file #762

Merged
merged 1 commit into from
Feb 26, 2021
Merged

add a document separator for storageclass template file #762

merged 1 commit into from
Feb 26, 2021

Conversation

nvnmandadhi
Copy link
Contributor

Is this a bug fix or adding new feature?
not a new feature

What is this PR about? / Why do we need it?
adds a document separator for storageclass template file

What testing is done?
tested using helm template

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @nvnmandadhi!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @nvnmandadhi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1625

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.656%

Totals Coverage Status
Change from base Build 1623: 0.0%
Covered Lines: 1736
Relevant Lines: 2126

💛 - Coveralls

Copy link

@georambo georambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. just encountered this as well.

@ayberk
Copy link
Contributor

ayberk commented Feb 24, 2021

Thanks for your contribution! Can you also please update the chart version. Otherwise our release workflow fails. But you might want to wait for #756 first.

Fixes #750.

@nvnmandadhi
Copy link
Contributor Author

thanks @ayberk, happy to help! yeah, will update the chart version after #756 is complete.

@ayberk
Copy link
Contributor

ayberk commented Feb 26, 2021

/lgtm
/approve

I'm going to merge multiple chart changes and update the version. Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk, georambo, nvnmandadhi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 26, 2021
@nvnmandadhi
Copy link
Contributor Author

/lgtm
/approve

I'm going to merge multiple chart changes and update the version. Thanks!

Sounds good, thank you @ayberk, I'm looking to work on more issues, could you suggest a task please?

@k8s-ci-robot k8s-ci-robot merged commit 1ca1f8b into kubernetes-sigs:master Feb 26, 2021
@ayberk
Copy link
Contributor

ayberk commented Feb 26, 2021

I'd keep an eye on good-first-issues :) Appreciate the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants