Generate webhook cert with 180 days validity #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakkinni, divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
divyenpatel
added a commit
to divyenpatel/vsphere-csi-driver
that referenced
this pull request
Aug 25, 2023
k8s-ci-robot
pushed a commit
that referenced
this pull request
Aug 25, 2023
omniproc
added a commit
to omniproc/vsphere-csi-driver
that referenced
this pull request
Jan 3, 2024
Extension to PR kubernetes-sigs#2514
omniproc
added a commit
to omniproc/vsphere-csi-driver
that referenced
this pull request
Jan 3, 2024
Extension to PR kubernetes-sigs#2514
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Webhook certificate validity is just 1 month.
Increasing validity to 180 days considering 1 month is very short for cert rotation.
Testing done:
Verified certificate validity after re-deploying webhook with updated script.
Special notes for your reviewer:
Release note: