-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webhook certs patch 1 #2739
Webhook certs patch 1 #2739
Conversation
Extension to PR kubernetes-sigs#2514
Extension to PR kubernetes-sigs#2514
Welcome @omniproc! |
Hi @omniproc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@omniproc can you fix linter issues? |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, omniproc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
636dc73 unfortunately only did half the job. This is a extension to that pull to actually fix the problem with the very short lived default webhook certificate.
Testing done:
Verified certificate validity after re-deploying webhook with updated script.
Special notes for your reviewer:
This is only a workaround for the existing issue with the current openssl / bash script approach. Obviously this hole approach is unreliable and certificate management should be outsourced to certmanager instead.