Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support session affinity via Ingress annotation #516

Closed
lornemet-eno opened this issue Oct 19, 2018 · 6 comments
Closed

Support session affinity via Ingress annotation #516

lornemet-eno opened this issue Oct 19, 2018 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lornemet-eno
Copy link

ingress.kubernetes.io/affinity annotation is currently discarded.
The expected behavior would be to disable/enable session affinity based on the annotations value:
none (default) -> NONE
cookie -> GENERATED_COOKIE
??? -> CLIENT_IP

While simply turning on session affinity in the GCE ingress itself would not enable session affinity down to the POD (GCE would still send traffic to the NodePort of computes in the resourcegroup, which would not care about HTTP cookies), but would eliminate the need of manual/out-of-kubernetes configuration if additional measures are implamented (ie deployment -> daemonset, or pod antiaffinity + externalTrafficPolicy: Local).

@rramkumar1
Copy link
Contributor

@lornemet-eno We will happily accept an implementation for this :)

See #513 for an example.

@bpineau
Copy link
Contributor

bpineau commented Oct 23, 2018

I happen to have the same need, I'll cook a PR (unless you started working on it @lornemet-eno ?)

@rramkumar1
Copy link
Contributor

@bpineau thanks for your work!

For everyone else, session affinity was implemented in #526

That code will be shipping in approximately 2 weeks or so.

@rramkumar1
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 31, 2018
@rramkumar1
Copy link
Contributor

FYI: This is now launched on GKE for cluster versions at or above 1.11.3-gke.18!

Docs: https://cloud.google.com/kubernetes-engine/docs/how-to/configure-backend-service

/close

@k8s-ci-robot
Copy link
Contributor

@rramkumar1: Closing this issue.

In response to this:

FYI: This is now launched on GKE for cluster versions at or above 1.11.3-gke.18!

Docs: https://cloud.google.com/kubernetes-engine/docs/how-to/configure-backend-service

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants