BackendConfig support for session affinity #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow user provided session affinity type and ttl. Sending e2e/fuzz tests on a distinct PR.
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
reviewed
Oct 25, 2018
| TimeoutSec *int64 `json:"timeoutSec,omitempty"` | ||
| ConnectionDraining *ConnectionDrainingConfig `json:"connectionDraining,omitempty"` | ||
| AffinityCookieTtlSec *int64 `json:"affinityCookieTtlSec,omitempty"` | ||
| SessionAffinity string `json:"sessionAffinity,omitempty"` |
There was a problem hiding this comment.
Can we encapsulate these settings in a struct? Something like this:
type SessionAffinityConfig struct {
SessionAffinityType string
AffinityCookieTtlSec *int64
}
pkg/backends/features/affinity.go
Outdated
|
|
||
| // Should we check if specified SessionAffinity is among the currently GCP supported values? | ||
| // For now let's forward as is to GCP, to inherit API error message (and evolutions). | ||
| // Same for TTL (should be in 0-86400 range). |
There was a problem hiding this comment.
Can we add this validation to pkg/backendconfig/validation.go?
That way, we can give feedback to the user before the LB starts to get created.
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
rramkumar1
reviewed
Oct 25, 2018
pkg/backendconfig/validation.go
Outdated
|
|
||
| if beConfig.Spec.SessionAffinity.AffinityType != "" { | ||
| if _, ok := supportedAffinities[beConfig.Spec.SessionAffinity.AffinityType]; !ok { | ||
| return fmt.Errorf("unsupported AffinityType: %s, sould be one of NONE, CLIENT_IP, or GENERATED_COOKIE", |
pkg/backendconfig/validation.go
Outdated
|
|
||
| if beConfig.Spec.SessionAffinity.AffinityCookieTtlSec != nil { | ||
| if *beConfig.Spec.SessionAffinity.AffinityCookieTtlSec < 0 || *beConfig.Spec.SessionAffinity.AffinityCookieTtlSec > 86400 { | ||
| return fmt.Errorf("unsupported AffinityCookieTtlSec: %d, should be comprised between 0 and 86400", |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpineau, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user provided session affinity type and ttl.
Sending e2e/fuzz tests on a distinct PR.