-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GKE self managed setup script should have an e2e test #760
Comments
/good-first-issue |
@KatrinaHoffert: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Note: should be viewed as dependent #759.
The script was broken already, so there's certainly merit in a test to avoid that. However, it's difficult because the test will be slow and require many things:
Things that could be done to make this task easier:
gce.conf
file could be split into their own functions and tested on their own, then the larger test can just use the CLI flags to override em.gcloud
,kubectl
, andmake
and just test what they execute. Would make it a unit test instead of an e2e test, but at least would catch changes and would be much faster to run.--dry-run
withkubectl
to at least confirm our YAML is valid (since that's one thing that was broken before!).The text was updated successfully, but these errors were encountered: