Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying to GKE self managed has invalid YAML #756

Merged
merged 1 commit into from
May 23, 2019

Conversation

KatrinaHoffert
Copy link
Contributor

This is for issue #755. Straightforward fix for the invalid syntax. I tested the script with this change.

Given that the invalid syntax should have prevented anyone from using the script, it is rather concerning. Implies no tests for this. But creating a meaningful test for it is quite non-trivial, so not doing that here.

@k8s-ci-robot
Copy link
Contributor

Welcome @KatrinaHoffert!

It looks like this is your first PR to kubernetes/ingress-gce 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-gce has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @KatrinaHoffert. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2019
@KatrinaHoffert
Copy link
Contributor Author

Gah, I have dirty commits on that branch, lemme clean it up.

This fixes the error:

```
error: error parsing ../resources/rbac.yaml: error converting
YAML to JSON: yaml: line 9: did not find expected key
```
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2019
@KatrinaHoffert
Copy link
Contributor Author

Ready for review.

@MrHohn
Copy link
Member

MrHohn commented May 23, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2019
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KatrinaHoffert, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 808925e into kubernetes:master May 23, 2019
@rramkumar1
Copy link
Contributor

rramkumar1 commented May 27, 2019

@KatrinaHoffert Thanks for the fix. For posterity, looks like the typo was introduced in #746. You are right that we need some unit testing around those files that lints the yaml at the very least. Thanks for filing the issue for that!

@KatrinaHoffert
Copy link
Contributor Author

I actually had already made a ticket for that. #760. It's a bit broader than just unit tests, but does mention similar, with points 2 and 3 of simplifying that.

@KatrinaHoffert KatrinaHoffert deleted the issue-755 branch May 27, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants