Condense backendPool and defaultBackendPool #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/L
nicksardo
reviewed
Apr 27, 2018
pkg/loadbalancers/l7s.go
Outdated
| return &L7s{cloud, storage.NewInMemoryPool(), nil, defaultBackendPool, defaultBackendNodePort, namer} | ||
| // - backendPool: Used to sync BackendServices with the cloud. | ||
| func NewLoadBalancerPool(cloud LoadBalancers, backendPool backends.BackendPool, namer *utils.Namer) LoadBalancerPool { | ||
| return &L7s{cloud, storage.NewInMemoryPool(), backendPool, namer} |
There was a problem hiding this comment.
My goal was that the load balancer pool doesn't need to have a reference to the backendpool.
There was a problem hiding this comment.
Good point, gonna work on this more to see if I can remove it from LB pool.
There was a problem hiding this comment.
I was able to remove the backend pool reference from the load balancer pool. This required some semi-significant refactoring but I think everything is a lot cleaner now.
There was a problem hiding this comment.
Removed the tests files just for clarity.
rramkumar1
force-pushed
the
default-backend-cleanup
branch
from
582717e
to
c1dfbbd
Compare
k8s-ci-robot
added
the
cncf-cla: yes
rramkumar1
changed the title
rramkumar1
force-pushed
the
default-backend-cleanup
branch
4 times, most recently
from
044c947
to
468956c
Compare
rramkumar1
force-pushed
the
default-backend-cleanup
branch
from
468956c
to
1fc6b2d
Compare
rramkumar1
changed the title
rramkumar1
force-pushed
the
default-backend-cleanup
branch
from
1fc6b2d
to
753e1f3
Compare
|
Test panicked. |
rramkumar1
force-pushed
the
default-backend-cleanup
branch
from
753e1f3
to
f368eb5
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to condense management of all backends into one backend pool. Users of the condensed backend pool can now access the default backend's NodePort through a method in the BackendPool interface.
/assign @nicksardo
Should fix #184 & #127