Merge the logic of ToUrlMap() and IngressToNodePorts() #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
changed the title
rramkumar1
force-pushed
the
merge-getting-svcports-with-urlmap-translation
branch
from
e886587
to
b55bd52
Compare
k8s-ci-robot
added
size/XL
rramkumar1
force-pushed
the
merge-getting-svcports-with-urlmap-translation
branch
from
b55bd52
to
00c3f96
Compare
|
Note: A bulk of the changes are to tests and the result of moving ServicePort to the utils package. |
rramkumar1
force-pushed
the
merge-getting-svcports-with-urlmap-translation
branch
from
00c3f96
to
d018477
Compare
rramkumar1
force-pushed
the
merge-getting-svcports-with-urlmap-translation
branch
from
d018477
to
26af836
Compare
|
Thanks for making the changes. |
k8s-ci-robot
added
the
lgtm
rramkumar1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to merge the logic of two function in the translator. Right now, ToUrlMap() and IngressToNodePorts() both iterate over an Ingress spec in very similar ways. In order to reduce complexity of having two similar code paths being executed at different times, we can merge these two functions together to ensure easier testing and maintainability.
This also gives us the opportunity to store all config in one place (GCEURLMap). Now, this struct uses a ServicePort to denote a backend rather than the backend's name. (credit to @nicksardo for this idea)
If this approach looks reasonable, I will add tests for it (there are no tests for any of this currently).
This PR is a prerequisite for condensing backend pool's (#242).
/assign @nicksardo