Merge pull request #66 from labstack/middleware

Fixed #65

README.md

@@ -90,15 +90,9 @@ func main() {
 	// Echo instance
 	e := echo.New()
 
-	//------------
 	// Middleware
-	//------------
-
-	// Recover
-	e.Use(mw.Recover())
-
-	// Logger
 	e.Use(mw.Logger())
+	e.Use(mw.Recover())
 
 	// Routes
 	e.Get("/", hello)

echo.go

@@ -22,6 +22,7 @@ type (
 		prefix           string
 		middleware       []MiddlewareFunc
 		maxParam         byte
+		notFoundHandler  HandlerFunc
 		httpErrorHandler HTTPErrorHandler
 		binder           BindFunc
 		renderer         Renderer
@@ -134,13 +135,16 @@ func New() (e *Echo) {
 	//----------
 
 	e.MaxParam(5)
+	e.notFoundHandler = func(c *Context) *HTTPError {
+		return &HTTPError{Code: http.StatusNotFound}
+	}
 	e.HTTPErrorHandler(func(he *HTTPError, c *Context) {
 		if he.Code == 0 {
 			he.Code = http.StatusInternalServerError
 		}
 		if he.Message == "" {
 			he.Message = http.StatusText(he.Code)
-			if e.debug {
+			if e.debug && he.Error != nil {
 				he.Message = he.Error.Error()
 			}
 		}
@@ -321,18 +325,19 @@ func (e *Echo) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	}
 	c.reset(w, r, e)
 	if h == nil {
-		c.Error(&HTTPError{Code: http.StatusNotFound})
-	} else {
-		// Chain middleware with handler in the end
-		for i := len(e.middleware) - 1; i >= 0; i-- {
-			h = e.middleware[i](h)
-		}
+		h = e.notFoundHandler
+	}
 
-		// Execute chain
-		if he := h(c); he != nil {
-			e.httpErrorHandler(he, c)
-		}
+	// Chain middleware with handler in the end
+	for i := len(e.middleware) - 1; i >= 0; i-- {
+		h = e.middleware[i](h)
 	}
+
+	// Execute chain
+	if he := h(c); he != nil {
+		e.httpErrorHandler(he, c)
+	}
+
 	e.pool.Put(c)
 }
 

examples/crud/server.go

@@ -61,8 +61,8 @@ func main() {
 	e := echo.New()
 
 	// Middleware
-	e.Use(mw.Recover())
 	e.Use(mw.Logger())
+	e.Use(mw.Recover())
 
 	// Routes
 	e.Post("/users", createUser)

examples/hello/server.go

@@ -16,15 +16,9 @@ func main() {
 	// Echo instance
 	e := echo.New()
 
-	//------------
 	// Middleware
-	//------------
-
-	// Recover
-	e.Use(mw.Recover())
-
-	// Logger
 	e.Use(mw.Logger())
+	e.Use(mw.Recover())
 
 	// Routes
 	e.Get("/", hello)

examples/middleware/server.go

@@ -23,12 +23,12 @@ func main() {
 	// Middleware
 	//------------
 
-	// Recover
-	e.Use(mw.Recover())
-
 	// Logger
 	e.Use(mw.Logger())
 
+	// Recover
+	e.Use(mw.Recover())
+
 	// Basic auth
 	e.Use(mw.BasicAuth(func(u, p string) bool {
 		if u == "joe" && p == "secret" {

examples/web/server.go

@@ -65,8 +65,8 @@ func main() {
 	e := echo.New()
 
 	// Middleware
-	e.Use(mw.Recover())
 	e.Use(mw.Logger())
+	e.Use(mw.Recover())
 
 	//------------------------
 	// Third-party middleware

router.go

@@ -310,9 +310,8 @@ func (r *router) ServeHTTP(w http.ResponseWriter, req *http.Request) {
 	h, _ := r.Find(req.Method, req.URL.Path, c)
 	c.reset(w, req, r.echo)
 	if h == nil {
-		c.Error(&HTTPError{Code: http.StatusNotFound})
-	} else {
-		h(c)
+		h = r.echo.notFoundHandler
 	}
+	h(c)
 	r.echo.pool.Put(c)
 }

website/docs/index.md

@@ -67,6 +67,7 @@ func main() {
 
 	// Middleware
 	e.Use(mw.Logger())
+	e.Use(mw.Recover())
 
 	// Routes
 	e.Get("/", hello)