Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware chain no longer traversed if no route found #65

Closed
Nomon opened this issue May 18, 2015 · 1 comment
Closed

Middleware chain no longer traversed if no route found #65

Nomon opened this issue May 18, 2015 · 1 comment
Assignees
Labels

Comments

@Nomon
Copy link

Nomon commented May 18, 2015

73fa05f (https://github.com/labstack/echo/blob/master/echo.go#L323) makes ServeHTTP skip all middlewares if no matching route is found.
This breaks among other things logging of 404 requests with logger middleware, also other middlewares we use like CORS/preflight for options requests do no longer work as we have no matching Options routes. Is this intended (and future) behavior to skip all the middlewares if no matching route is found or is it a bug?

@vishr vishr added the bug label May 18, 2015
@vishr vishr self-assigned this May 18, 2015
@vishr
Copy link
Member

vishr commented May 18, 2015

It's a bug.

@vishr vishr closed this as completed in aa5e552 May 18, 2015
vishr added a commit that referenced this issue May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants