Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve request binding documentation. See Echo pull request #1681 #169

Merged

Conversation

aldas
Copy link
Contributor

@aldas aldas commented Dec 12, 2020

Improve request binding documentation. This PR should be merged after labstack/echo#1681 is merged

NB: I'm not that good at English. Feel free to modify sentences before/during merging

@aldas aldas force-pushed the issue_1681_improve_request_binding_docs branch from 6ecdfc8 to f0674ea Compare December 13, 2020 09:21
@lammel
Copy link
Contributor

lammel commented Dec 14, 2020

Great! Let us wait with the merge until labstack/echo#1681 is resolved to be sure wew are documenting the real thing.

@lammel lammel added the docs label Dec 14, 2020
@lammel
Copy link
Contributor

lammel commented Jan 5, 2021

Time to wait is over labstack/echo#1681 is merged ;-)

@lammel lammel merged commit ca35791 into labstack:master Jan 31, 2021
@lammel
Copy link
Contributor

lammel commented Jan 31, 2021

Merged. Next up is #172 for the fluent binder

@aldas aldas deleted the issue_1681_improve_request_binding_docs branch February 23, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants