Docs for #1736 fluent binder #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pafuent
reviewed
Jan 6, 2021
website/content/guide/request.md
Outdated
| ``` | ||
|
|
||
| ### Methods | ||
| `FailFast` flags binder to stop binding after first bind error during binder call chain. Enabled by default. |
There was a problem hiding this comment.
I think FailFast should include the () to be consistent
website/content/guide/request.md
Outdated
|
|
||
| * `<Type>("param", &destination)` - if parameter value exists then binds it to given destination of that type i.e `Int64(...)`. | ||
| * `Must<Type>("param", &destination)` - parameter value is required to exist, binds it to given destination of that type i.e `MustInt64(...)`. | ||
| * `<Type>s("param", &destination)` - (for slices) if parameter values exists then binds it to given destination of that type i.e `I`nt64s(...)`. |
There was a problem hiding this comment.
Here there is a extra ` after the I (`I`nt64s(...)`)
website/content/guide/request.md
Outdated
| * `<Type>s("param", &destination)` - (for slices) if parameter values exists then binds it to given destination of that type i.e `I`nt64s(...)`. | ||
| * `Must<Type>s("param", &destination)` - (for slices) parameter value is required to exist, binds it to given destination of that type i.e `MustInt64s(...)`. | ||
|
|
||
| for some slice types `BindWithDelimiter("param", &dest, ",")` supports slitting parameter values before type conversion is done |
Mention `UnixTimeNano()` as supported fluent binder function
|
lgtm. I added 2 little changes:
splitting binder to its own page is good move. It is easier to find it on site. |
pafuent
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for:
Maybe someone with better English takes time to edit wording etc if needed.