Enable pylint and other linting rules in ruff #417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But don't enable ruff format preview mode, since we don't want their parentheses formatting yet (hug_parens_with_braces_and_square_brackets)
These rules can be used again now that preview mode is enabled
jvavrek
reviewed
May 30, 2024
Comment on lines
+1438
to
+1439
| s += "X units: {:s}\n".format(self.xmode or "None") | ||
| s += "Y units: {:s}\n".format(self.ymode or "None") |
There was a problem hiding this comment.
I dislike this change---it relies on a subtlety unique to python that not even many intermediate python programmers know, just for the sake of a little brevity. Could we disable this?
There was a problem hiding this comment.
Your alternate idea: convert both to f"{str(self.xymode)}" for maximum conciseness.
There was a problem hiding this comment.
This is almost certainly FURB110
| @@ -95,7 +95,7 @@ def read(filename, verbose=False, cal_kwargs=None): | |||
| energy_channel_pairs = [] | |||
| energy_res_pairs = [] # currently unused | |||
| energy_eff_pairs = [] # currently unused | |||
| with Path(filename).open() as f: | |||
| with Path(filename).open(encoding="utf-8") as f: | |||
| @@ -31,7 +31,7 @@ def sim_data(x_min, x_max, y_func, num_x=200, binning="linear", **params): | |||
| edges = np.linspace(x_min, x_max, num_x, dtype=float) | |||
| elif binning == "sqrt": | |||
| edges = np.linspace(np.sqrt(x_min), np.sqrt(x_max), num_x) | |||
| edges = edges**2 | |||
| edges **= 2 | |||
|
I will redo this PR without implementing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the following rulesets in
ruff:SIM: flake8-simplify rules to simplify codePL: pylint rules to "check[] for errors, enforce[] a coding standard, look[] for code smells, and [] make suggestions about how the code could be refactored"FURB: refurb, "for refurbishing and modernizing Python codebases"I thought these made useful improvements and would be helpful for maintaining our code going forward.