Enable pylint and other linting rules in ruff #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by ruff rule PLW3201, which is only part of ruff preview mode, but it seems like a good change to make at this point.
jvavrek
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the following rulesets in
ruff:SIM: flake8-simplify rules to simplify codePL: pylint rules to "check[] for errors, enforce[] a coding standard, look[] for code smells, and [] make suggestions about how the code could be refactored"I thought these made useful improvements and would be helpful for maintaining our code going forward.
This PR is a second take on #417 but without the experimental rules from
ruff'spreviewmode.