Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "function" test against regular expressions #1773

Merged
merged 2 commits into from
Jan 3, 2014
Merged

Fixes "function" test against regular expressions #1773

merged 2 commits into from
Jan 3, 2014

Conversation

matthew-dean
Copy link
Member

In some browser engines (especially older versions of Webkit), this
test fails when the argument is a RegExp.

See:
http://stackoverflow.com/questions/5054352/why-use-typeof-for-identifying-a-function

Fix tested and works with Adobe AIR.

In some browser engines (especially older versions of Webkit), this
test fails when the argument is a RegExp.

See:
http://stackoverflow.com/questions/5054352/why-use-typeof-for-identifyin
g-a-function

Fix tested and works with Adobe AIR.
@matthew-dean
Copy link
Member Author

Er, I wasn't sure how to make a new pull request. Fork the main repo again? These are technically my first pull requests, be gentle.

lukeapage added a commit that referenced this pull request Jan 3, 2014
Fixes "function" test against regular expressions
@lukeapage lukeapage merged commit 029f016 into less:master Jan 3, 2014
@lukeapage
Copy link
Member

all good. I'll add a comment against the function check change once merged.

@matthew-dean
Copy link
Member Author

Out of curiosity, how would you get these into separate pull requests? What I did was delete my less.js fork, create a new one, make one change, commit and pull, make the other, commit and pull. But the second pull did both, because both commits were still technically different from the main repo.

Also, note that I didn't run tests other than my specific environment. I'll try to figure that out too, but I thought I could get the ball rolling.

@lukeapage
Copy link
Member

A pull request is everything from one branch.. so when you committed the
second time it updated the pull request.

Its best to instead do each patch on a new branch.. e.g.
Git branch patch-1
Git commit
Git push (may need to set the remote here to create a new branch on the
server)
Git checkout master -b patch-2
Etc.

With 2 commits on master already, write down the sha hash codes from git
log, reset, branch and then cherry pick your commit on to each branch
seperately..

The tests are quite easy to install and run and you just get a yes or no on
the cli. I think the full instructions are on that development page.

@matthew-dean
Copy link
Member Author

Ah, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants