Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color function updates - #RRGGBBAA and CSS Variables #3291

Merged
merged 4 commits into from
Jul 29, 2018
Merged

Color function updates - #RRGGBBAA and CSS Variables #3291

merged 4 commits into from
Jul 29, 2018

Conversation

matthew-dean
Copy link
Member

@matthew-dean matthew-dean commented Jul 17, 2018 •
edited
Loading

Fixes #3290, #2986, #3176, #1665

  • Allows #RRGGBBAA colors
  • Outputs color functions as-is when there are unrecognized properties (allows using CSS variables for args, for example)
  • Keeps colors in the same color space when possible. e.g. spin(hsl(50, 1%, 10%), 10) becomes hsl(60, 1%, 10%) vs converting to rgba()
  • Adds the rgba(<Color> [, <opacity>]) and hsla(<Color> [, <opacity>]) 1- or 2-argument forms for those functions

@matthew-dean matthew-dean mentioned this pull request Jul 17, 2018
Closed
@matthew-dean matthew-dean changed the title Supports #RRGGBBAA color form Color function updates - #RRGGBBAA and CSS Variables Jul 18, 2018
@matthew-dean
Copy link
Member Author

Updated, see: #3290 (comment)

calvinjuarez
calvinjuarez approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@calvinjuarez calvinjuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@matthew-dean
Copy link
Member Author

@calvinjuarez Thanks for reviewing!

@matthew-dean matthew-dean merged commit a9c69a3 into less:master Jul 29, 2018
@matthew-dean matthew-dean mentioned this pull request Aug 6, 2018
Closed
@michaeltaranto michaeltaranto mentioned this pull request Oct 17, 2018
Merged
@arronKler arronKler mentioned this pull request Aug 30, 2021
Closed
@Krinkle Krinkle mentioned this pull request Sep 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinjuarez calvinjuarez calvinjuarez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthew-dean @calvinjuarez