fix(deps): Upgrade Less to v3 #190
Conversation
|
I did find |
| @@ -26,8 +26,8 @@ Object { | |||
| ._3Zn-PeU{border-radius:4px} | |||
| ._1sseFqJ{border-style:solid;border-width:1px} | |||
| ._1d6RKtE{-webkit-box-shadow:0 0 0 1px #2765cf;box-shadow:0 0 0 1px #2765cf} | |||
| .mT50rPc{color:#1c1c1c}._1Rsg9w6{color:#fff}._3OSCp5v{color:#e60278}.AsBZy5a{color:green}._1DYv5gu{color:#1c1c1ca1 a1}._3rwI692{color:#2765cf} | |||
| ._16w04Xz{fill:currentColor}._1srDitw{fill:#2765cf}.hK-SldW{fill:#ccc}._3SkkQl1{fill:#e60278}.q2J3ENx{fill:green}._2WNYdGY{fill:#1c1c1ca1 a1}.QR_XQhw{fill:#fff} | |||
| .mT50rPc{color:#1c1c1c}._1Rsg9w6{color:#fff}._3OSCp5v{color:#e60278}.AsBZy5a{color:green}._1DYv5gu{color:#1c1c1ca1}._3rwI692{color:#2765cf} | |||
There was a problem hiding this comment.
@markdalgleish any idea if this change in the snapshot is meaningful (ie did I just legit ignore a broken test)
There was a problem hiding this comment.
First glance, this looks like a broken test.
There was a problem hiding this comment.
Looking at the original snap it appears less was repeating the opacity, maybe as some kind of compatibility issue? I don't think that's a problem if they've dropped that behaviour 🤔
There was a problem hiding this comment.
Oh, sorry—didn't realise the summary version wasn't showing me the full diff. It looked like an entire line of CSS had been removed. I see what you mean now 👍
There was a problem hiding this comment.
This seems to be the result of v3.8.1 adding support for #RRGGBBAA. Highlights an interesting scenario though, snapshots here can change based on internal braid-design-system changes.
|
Awesome, those warnings have been bugging me! |
| const fs = require('fs').promises; | ||
| const { F_OK } = require('fs').constants; | ||
| const fs = require('fs-extra'); | ||
| const { F_OK } = require('fs-extra').constants; |
There was a problem hiding this comment.
F_OK seems to be unused here
| const fs = require('fs').promises; | ||
| const { F_OK } = require('fs').constants; | ||
| const fs = require('fs-extra'); | ||
| const { F_OK } = require('fs-extra').constants; |
|
@mbfisher credit goes to Chia Lun in the Bricks team in Penang who was also bothered and reached out :) |
markdalgleish
changed the title
npm auditraises some prototype pollution errors that trace back to dependencies of dependencies of our dusty old version of less. Bumping to 3 appears to be non-traumatic.