Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

holepunch: fix incorrect message type for the SYNC message, release v0.19.2 #1479

Merged
merged 2 commits into from
May 11, 2022
Merged

holepunch: fix incorrect message type for the SYNC message, release v0.19.2 #1479

merged 2 commits into from
May 11, 2022

Conversation

marten-seemann
Copy link
Contributor

No description provided.

@marten-seemann marten-seemann requested a review from vyzo May 10, 2022 20:23
@marten-seemann marten-seemann changed the base branch from master to release-branch May 10, 2022 20:25
@laurentsenta laurentsenta mentioned this pull request May 11, 2022
Closed
@galargh
Copy link
Contributor

galargh commented May 11, 2022

I'm closing and reopening the PR to see if that has any effect on the release-check workflow.

@galargh galargh closed this May 11, 2022
@galargh galargh reopened this May 11, 2022
@github-actions
Copy link

Suggested version: v0.19.2
Comparing to: v0.19.1 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# summary
Suggested version: v0.19.2

gocompat says:

(empty)

Cutting a Release (when not on master)

This PR is targeting release-branch, which is not the default branch.
If you wish to cut a release once this PR is merged, please add the release label to this PR.

@marten-seemann
Copy link
Contributor Author

Thank you @galargh and @laurentsenta!

MarcoPolo
MarcoPolo reviewed May 11, 2022
View reviewed changes
p2p/protocol/holepunch/holepunch_test.go
require.Equal(t, events[2].Type, holepunch.EndHolePunchEvtT)
require.Equal(t, holepunch.StartHolePunchEvtT, h2Events[0].Type)
require.Equal(t, holepunch.HolePunchAttemptEvtT, h2Events[1].Type)
require.Equal(t, holepunch.EndHolePunchEvtT, h2Events[2].Type)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you check if it was successful here? (by checking this field maybe:

go-libp2p/p2p/protocol/holepunch/tracer.go

Line 180 in 41902ec

Success: err == nil,
)

Or do you just care that this attempt happened and not necessarily that it was successful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Let's fix this on master though, not in this backport.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, on this peer's side Success will be true even if it just sent the CONNECT instead of the SYNC message.

@marten-seemann marten-seemann merged commit 4c81b3a into release-branch May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo left review comments

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marten-seemann @galargh @vyzo @MarcoPolo