fix: close webrtc streams #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome does not always send all messages after closing a datachannel even if `bufferedAmount` is `0` before closing. This PR adds a `FIN_ACK` message that is sent in reply to a `FIN` message - because all messages are send in-order, when this is received we know the remote has recieved all of our data messages and it's safe to close the channel.
3 tasks
|
The spec changes have been merged so I'm going to merge this into the other WebRTC PR so we can land both together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome does not always send all messages after closing a datachannel even if
bufferedAmountis0before closing.This PR adds a
FIN_ACKmessage that is sent in reply to aFINmessage - because all messages are send in-order, when this is received we know the remote has recieved all of our data messages and it's safe to close the channel.