Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close webrtc streams #2074

Merged
merged 11 commits into from
Oct 5, 2023
Merged

fix: close webrtc streams #2074

merged 11 commits into from
Oct 5, 2023

Commits on Sep 23, 2023

  1. fix: add FIN_ACK message to WebRTC streams to prevent early closing 

    Chrome does not always send all messages after closing a datachannel
even if `bufferedAmount` is `0` before closing.

This PR adds a `FIN_ACK` message that is sent in reply to a `FIN`
message - because all messages are send in-order, when this is
received we know the remote has recieved all of our data messages
and it's safe to close the channel.
    @achingbrain
    achingbrain committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    7d1ff01 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Merge branch 'fix/webrtc-stream-closing' into fix/add-webrtc-fin-ack

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    7fada6c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/webrtc-stream-closing' into fix/add-webrtc-fin-ack

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    35cc13b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/webrtc-stream-closing' into fix/add-webrtc-fin-ack

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    08a9d13 View commit details
    Browse the repository at this point in the history

  4. chore: send/wait for FIN_ACK on close

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    9ef3fcb View commit details
    Browse the repository at this point in the history

  5. chore: restore status

    @achingbrain
    achingbrain committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    565b91e View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. chore: remove unused flag

    @achingbrain
    achingbrain committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    4d97a96 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. chore: add tests for fin_ack

    @achingbrain
    achingbrain committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    15495fc View commit details
    Browse the repository at this point in the history

  2. chore: fix tests

    @achingbrain
    achingbrain committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    0001649 View commit details
    Browse the repository at this point in the history

  3. chore: fix linting

    @achingbrain
    achingbrain committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    ec0ec5f View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. fix: do not wait to send fin_ack

    @achingbrain
    achingbrain committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    d76bb7b View commit details
    Browse the repository at this point in the history